Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vectorize basic_string::find (the string needle overload) #5048

Merged
merged 11 commits into from
Oct 30, 2024
Merged

Vectorize basic_string::find (the string needle overload) #5048

merged 11 commits into from
Oct 30, 2024

Conversation

AlexGuteniev
Copy link
Contributor

Towards #5036

Benchmark main this
member_find<std::string>/0 1149 ns 292 ns
member_find<std::string>/1 1174 ns 300 ns
member_find<std::string>/2 52.1 ns 31.5 ns
member_find<std::string>/3 30.4 ns 18.1 ns
member_find<std::string>/4 14420 ns 1395 ns
member_find<std::string>/5 22193 ns 11719 ns
member_find<std::wstring>/0 943 ns 502 ns
member_find<std::wstring>/1 1087 ns 594 ns
member_find<std::wstring>/2 81.5 ns 58.6 ns
member_find<std::wstring>/3 42.5 ns 28.6 ns
member_find<std::wstring>/4 6463 ns 7656 ns
member_find<std::wstring>/5 18725 ns 21484 ns

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner October 27, 2024 20:38
@StephanTLavavej StephanTLavavej added the performance Must go faster label Oct 27, 2024
@StephanTLavavej StephanTLavavej self-assigned this Oct 28, 2024
@StephanTLavavej StephanTLavavej removed their assignment Oct 29, 2024
@StephanTLavavej StephanTLavavej mentioned this pull request Oct 29, 2024
Open
@StephanTLavavej
Copy link
Member

Thanks! 🧶 I pushed a minor stylistic change and a syntax fix.

@StephanTLavavej StephanTLavavej self-assigned this Oct 29, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 5e8f003 into microsoft:main Oct 30, 2024
39 checks passed
@StephanTLavavej
Copy link
Member

Thanks for extending vectorization to this important member function! 🚀 ✨ 💚

@AlexGuteniev AlexGuteniev deleted the strstr branch October 30, 2024 15:01
@AlexGuteniev AlexGuteniev mentioned this pull request Oct 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
performance Must go faster
Projects
STL Code Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexGuteniev @StephanTLavavej